2023 06 20 Besu Contributor Call
Gabriel Trintinalia: I saw it. Sally MacFarlane: We'll give everyone a few minutes to join Gabriel Trintinalia: by. Then Sally MacFarlane: we'll give everyone a few more minutes to join.
Gabriel Trintinalia: Yeah, sure. Share my screen. Sally MacFarlane: The agenda.
Simon (siladu): Hi, Simon! Gabriel Trintinalia: It's time on! Simon (siladu): There they go! Sally MacFarlane: We might kick off, and like Sally MacFarlane: one more minute. Sally MacFarlane: I can't buy my clock. That's one moment I will start Sally MacFarlane: So Sally MacFarlane: I am already sharing my screen. Yes, Sally MacFarlane: agenda housekeeping first off the and I just notice everyone on the call should be already familiar with that. If you're not at the link Sally MacFarlane: anything recorded me just I think we need to worry about the right hand.
It's only a handful of people on the call Sally MacFarlane: feel free to interrupt me if you have a question comment. Sally MacFarlane: general announcement, I don't have any. Sally MacFarlane: Does anyone on the call have any general announcement? Simon (siladu): hmm.
Sally MacFarlane: okay, Sally MacFarlane: the roadmap. Sally MacFarlane: I actually don't know, if that's been updated recently. Sally MacFarlane: I think at the moment we're all about. And Sally MacFarlane: yeah, I think that's fairly up today.
Sally MacFarlane: okay, release updates, we might actually. Sally MacFarlane: I was, gonna say, skip that and move on wedding for stuff on his doing the ben in. But Sally MacFarlane: we can probably do the updated way. So 23, 4, 2 that, and then on Friday as I understand it, there's an issue with the spot database Sally MacFarlane: new feature. So there was a no corner exception that fixes already gone in for that this morning. Sally MacFarlane: So the plan is to restart like start an event. And basically Sally MacFarlane: because.
Sally MacFarlane: as I, my understanding is that we really want that database to be the Sally MacFarlane: so Sally MacFarlane: key feature in this new release. So without the flat database in those behind an experimental Sally MacFarlane: right Sally MacFarlane: we kind of want that in the release. So we're starting a new burning Sally MacFarlane: today. Any comments on that. Simon (siladu): I think it's Simon (siladu): I. I I'm not too familiar with it. Yeah, but I think it's it's the heel mechanism for the flat database Simon (siladu): rather than Simon (siladu): well, so it's like. Simon (siladu): I think we we've always had the flat database, but it's Simon (siladu): I guess, filling, filling it to Simon (siladu): pretty complete. I think his boss this is doing
Sally MacFarlane: right. Gotcha Simon (siladu): but yeah, it looks like it was Simon (siladu): some kind of refactoring was done. This is feature toggle, but there was some refactoring done Simon (siladu): that affected the when the feature was off as well, and that was where the bug was and I think it was. I think there's a point around this around how we
Simon (siladu): like review and test Pr, especially big ones. I think what might have happened here is that it was, like all tested, thoroughly tested, and reviewed, and stuff. But then changes remained as a result of the review. Simon (siladu): and some of the re testing was missed. I with the featured like. Oh. Simon (siladu): So I think Simon (siladu): I I mean, ultimately he. The proposal about the change to the release process. But it's
Simon (siladu): I think it's it's very owners to have to retest everything. Why not? Simon (siladu): So? I think 1 one thing we could do in the short term is. Simon (siladu): maybe we do most of the Co review before most of the testing, if that makes sense. But you you probably always gonna have to do some some manual test to make sure you think you're ready? Simon (siladu): but maybe we should kind of Simon (siladu): default to like getting the code ready to review before we do like the most extensive Simon (siladu): portion of the test Simon (siladu): that my output I I mean, this is all kind of some ad hoc, and there's no Simon (siladu): all right official process around it, anyway. But it's with probably mentioning in chat about really Simon (siladu): so like, I guess it's relevant, if like, if you're reviewing the Pr and asking about the testing and stuff like this Simon (siladu): which I've done before, like I think it's probably worth. Be in mind that maybe we should test at the end just before merge, because 1 one small line could break everything. Simon (siladu): the Sally MacFarlane: yeah, it's it's a fair point.
Sally MacFarlane: I I'd really like to see more of this automated, because I feel like as long as it's manual. And we're relying on, you know, individual Sally MacFarlane: individuals to to always do the right thing. It's just it's just error. Prime. Simon (siladu): Exactly. Yeah. And and this is well, I I guess. Might as well talk about it. It's kind of related to Simon (siladu): what I'm trying to get out with the burning process changing the is that we like we we are effectively relying on the burning process. Cache things like this which it did, which is good. Simon (siladu): What that means is especially the fact that it was over. The weekend
Simon (siladu): means that I think like a release cycle. Well, Simon (siladu): the time, what's the word like lead time for for completing a piece is actually because of that. And I think we got quite lucky with this one. It it was really obvious which committed it was because of the that trace. But Simon (siladu): I think if you have, you know, multiple commits or maybe doing, but it changes. And now. Simon (siladu): relying on the not that they are overlying. But you know, I mean if if you Simon (siladu): and they can be caught. difficult to to find the issue. So basically long winded way of saying, I agree with you, I think we should put time into.
Simon (siladu): That's a regression test, which is kind of the point of proposal as well. Sally MacFarlane: So the proposal you're talking about is this one. Simon (siladu): But the Simon (siladu): so yeah, Simon (siladu): maybe I should wait till we get to that. Simon (siladu): Yeah. But basically, I think where we are with this is that
Simon (siladu): I don't think this too much puts push back around. Simon (siladu): replacing the quarterly releases with a deprecation policy. Simon (siladu): so I think I'd be happy to kind of do the final call for that bit and and start actioning that after maybe the next Simon (siladu): one of these calls in the other times, and just get one final chance. That piece of it, I think, is is good to go Simon (siladu): and then also Simon (siladu): suggesting about effectively, well, keeping the main that's release full of it says that which would mean Simon (siladu): like. you don't really need a burning, because all the testing has happened before main. Simon (siladu): Not really. We can't obviously do that right away. I think it's too error to to rely on Simon (siladu): the testing and retesting and stuff in Prs to happen.
Simon (siladu): I do agree. There was some pushback about, not for me. But I'm processed. I do agree with that. Simon (siladu): but I think it'd be good to get like a commitment. Simon (siladu): But the direction we want to move in is to replace the burning with regression tests. Sally MacFarlane: Yeah, I I like the idea of having the regression tests that would be run on every Pr that would make sure. Yeah, there's no regressions, basically
Sally MacFarlane: and then that would definitely Sally MacFarlane: reduce the number of errors that the burning might catch, and maybe maybe it would. Totally. Sally MacFarlane: I don't know. I feel like they they kind of 2 different questions. But yeah, I hey. yeah. Simon (siladu): yeah, it's all about the speed of the feedback L, really, and the but it is quite a reliable and catching some, a lot of bugs.
Simon (siladu): Yeah, but it when when something does happen like this, then you see how kind of painfully so it is because it's going to be, you know. Basically a week it's taken. It will have taken us to release by the end of the second round. Sally MacFarlane: Yes. So then, what are the next steps? Simon (siladu): so yeah, it would be good to get kind of point Simon (siladu): purple agreement. But people who are interested to that like we're looking towards. Simon (siladu): we that every question test and like Simon (siladu): definitely, not in the very back, I guess, would be the the end goal. With that Simon (siladu): and yeah, we could trial the application. That is thing. As soon as kind of everyone agrees, I guess, but I guess the next step is to not do the next call to the release Simon (siladu): and maybe update the change log with any breaking changes that would have gone in there Simon (siladu): and decide how long they need to be. We need to wait. I think it's what I put in this suggested policy that everybody. you know it's made up to the to decide how long we should wait
Simon (siladu): for that change that they want to make. Simon (siladu): So yeah, so formalizing the suggested policy, I guess would be kind of the next step in that. And then. Sally MacFarlane: okay, so Sally MacFarlane: sorry did I miss any next steps. I think it would be good to sort of Simon (siladu): they not catches it. Yeah. Yeah. Sally MacFarlane: Okay. Cool. Sally MacFarlane: Awesome.
Sally MacFarlane: Okay. We might go back up to to leave. Sally MacFarlane: Okay, any anyone comment on the release. Sally MacFarlane: Simon, you did the last release. Do you know, can we update the 23, 4 to release that we already Sally MacFarlane: sort of started? Or do we need to? Does the next one need to be 23 Sally MacFarlane: like, can we? Can we patch this really? So doing. Into just go the next one.
Simon (siladu): good question. I think technically, you can Simon (siladu): think, maybe when this is happening in the past, we bump the version. Sally MacFarlane: Yeah, I feel like it's clear out if we just bump the version, and we say 23, four-two bio, and then the next one's 23, 4, 3. Simon (siladu): I it. Yeah, it won't avoid any any issues, for sure it's not too much that. But Simon (siladu): yeah, I let me take that offline and double check. But Simon (siladu): yeah, I don't know if it's really a huge issue if we can announce it. But it's, you know, technically, people might have pulled the code already, and it's a change from them which isn't great, maybe especially on the docket guys.
Sally MacFarlane: Yes. Sally MacFarlane: okay, cool. Thank you. Yeah. I will confirm off on. Sally MacFarlane: okay. So next item on the agenda is about 4 or 4, Sally MacFarlane: the embryo, do you want to give a quick update on that? Gabriel Trintinalia: Yeah. Gabriel Trintinalia: the majority of desks are implemented like the outstanding desks that we had for 7. At 6
the pr is marked as ready for reveal. Gabriel Trintinalia: I think the goal is to merge that into main. Gabriel Trintinalia: and the next 6 doesn't seem to be as it's more as it was supposed to be. Gabriel Trintinalia: there were some issues there, and Gabriel Trintinalia: apparently they are kind of different, for its clients are following different forks. Gabriel Trintinalia: But it's being investigated. Sally MacFarlane: And the. it's not just basic right.
Gabriel Trintinalia: I don't think it's just based on yes. Now. Sally MacFarlane: yeah. Cool Sally MacFarlane: the way keeping up. Oh, no. Sally MacFarlane: that you know, we're on part with the other clients at the moment. Gabriel Trintinalia: Yeah, yeah, I think we are Sally MacFarlane: cool. Gabriel Trintinalia: Justin is going to investigate on his back tonight.
Sally MacFarlane: Okay, cool. Sally MacFarlane: so other business. We kind of covered the Sally MacFarlane: avoid cherry page released Sally MacFarlane: process.
Sally MacFarlane: So the next one on the agenda is the debug log improvement proposal. Sally MacFarlane: I think I have that? Sally MacFarlane: Yeah. So this one is just about basically Sally MacFarlane: making debug level logging use, actually useful for people who are trying to debug stuff. Right? Simon (siladu): Yeah, I I haven't had any kind of disagreement with this. in principle like it might be a big. I just kind of repeat this here to to in this. More people see it, and
Simon (siladu): nicely, Charlotte, if you go any objections, and Simon (siladu): as well and hopefully we can. Simon (siladu): I think it's the kind of the fiscal policy. And then we kind of try and stick to this. Sally MacFarlane: Yeah, I I think that might be Simon (siladu): no, this is quite today, still, to the existing books. But that's just yeah.
Sally MacFarlane: yes, it works kind of under way on that right? This already. Some pr, and I guess if people Sally MacFarlane: developers, users notice things that are. Sally MacFarlane: you know, to noisy at debug level, we could raise issues. Simon (siladu): Yeah, I mean it. Just I just wanted to kind of. Simon (siladu): I guess. Get an agreement to socialize the thing to aim for for debug, and and then hopefully, it will get picked up in reviews and things. So
Sally MacFarlane: and we sign up for the next steps on that one as well. Simon (siladu): well, I I can't remember if I put it on the agenda for the other time zone. Simon (siladu): Oh, sorry! I'll do it at least once more there and then. Simon (siladu): if no one can. about it.
Sally MacFarlane: What's the best place for people to give like if someone is. Sally MacFarlane: Yes, I agree. What's the best place to do that? Simon (siladu): I guess it's easy to traffic. It's on the proposal itself on the actual proposal.
Simon (siladu): I'll be watching discord anyway. So this would work as well. Simon (siladu): Yeah, I haven't particularly mentioned it in discord. I will do before. Kind of finalize it. Simon (siladu): just to make sure everyone's seen it. Sally MacFarlane: Hello! Sally MacFarlane: okay, that's everything that's on the agenda. Anything else anyone wants to raise. Sally MacFarlane: No awesome. Sally MacFarlane: Let's call it done Simon (siladu): here.
Sally MacFarlane: Thanks all. Simon (siladu): Thank you.
2023-06-29 01:50
